search

JackDanielsAndCode / react-native-multi-slider

Pure JS react native slider component with one or two markers.
MIT License
151 stars 96 forks source link

Upgrade version #53

Open bridgewaterlabs opened 6 years ago

bridgewaterlabs commented 6 years ago

Hi,

it seems you did not update the version when updating View.propTypes to ViewPropTypes

this is an issue as now it doesn't want to update to proper version bump it up to 0.3.7

Thanks Alex

bridgewaterlabs commented 6 years ago

or it seems you did not publish it to NPM I am getting old version with View.propTypes.style when installing

MaxInMoon commented 6 years ago

View.propTypes breaks at least iOS release build (react-native@0.53.3) Seems urgent :)

I think there is a small (2h) global re-work to do on the code (es6, eslint, flow, etc.)

bridgewaterlabs commented 6 years ago

seems it's actually reworked but same version and not pushing to npm does not let me upgrade to new code ... so every time there needs to be manual work, I Will try to add repository as npm source

meh

Slessi commented 6 years ago

Pretty annoying but for the time being...

"dependencies": {
    "react-native-multi-slider": "JackDanielsAndCode/react-native-multi-slider#master"
}