search

JackDotJS / minecraft-asset-extractor

A dead-simple web application for extracting (Java Edition) Minecraft's built-in game assets.
MIT License
4 stars 0 forks source link

Add PWA support #10

Closed RobertRR11 closed 1 year ago

RobertRR11 commented 1 year ago

WIP because of various things missing. Just wanted to create this pull request to work on it tomorrow. Todo:

RobertRR11 commented 1 year ago

forgot to mention #9

JackDotJS commented 1 year ago
  • [ ] various icon sizes and monochrome icon

i can handle making new sets of app icons x) i've been wanting to update the design anyway, the current icon is years old now

RobertRR11 commented 1 year ago

Alright, also here is a list of some icon sizes you would need for a PWA

JackDotJS commented 1 year ago

do you still need a monochrome icon btw?

RobertRR11 commented 1 year ago

I can't verify if this is still accurate, but from what I heard, safari uses monochrome SVG icons for tabs, idk if we need this image

JackDotJS commented 1 year ago

i probably should've taken a closer look at this 😅 found a couple issues almost immediately after merging

thank you for the contribution regardless!!!!