JackDotJS / minecraft-asset-extractor

A dead-simple web application for extracting (Java Edition) Minecraft's built-in game assets.
MIT License
4 stars 0 forks source link

(WIP) version search #18

Closed RobertRR11 closed 7 months ago

RobertRR11 commented 1 year ago

To be honest I actually have no clue how typescript works

JackDotJS commented 1 year ago
  • [ ] fallback for version fetching (maybe hardcoded json file?)
  • [ ] getting rid of flickering when updating version list

can u elaborate on these?

RobertRR11 commented 1 year ago

fallback for version fetching (maybe hardcoded json file?)

For when Mojang API is down or any other network issue

getting rid of flickering when updating version list

Right now when you filter versions, the whole list gets removed and added again, which shifts the whole page for a very short time. This could probably be solved by just making the list a fixed height

JackDotJS commented 1 year ago

For when Mojang API is down or any other network issue

shouldn't we just list what versions the user has installed? assuming we're sticking with local files only for now

Right now when you filter versions, the whole list gets removed and added again, which shifts the whole page for a very short time. This could probably be solved by just making the list a fixed height

the list should already be a fixed height. otherwise, adding more items would extend the entire page instead of showing a scroll bar x)

i can't imagine why the whole page would shift if we're changing elements within an overflow element...

RobertRR11 commented 1 year ago

the list should already be a fixed height.

The list only has a max height. While the list elements are removed for the short amount of time, the list will get smaller than the max height and shift the page

JackDotJS commented 1 year ago

i-

image

WHY THE FUCK DID I MAKE IT A MAX HEIGHT.