JackDotJS / node-studio

Node-based music production tool, built with Tauri.
MIT License
7 stars 1 forks source link

Migrate from ESLint to Biome #52

Open bdotsamir opened 2 months ago

bdotsamir commented 2 months ago

Frankly, eslint has left a bad taste in my mouth for quite some time now. Every time I've set it up, it's been a pain to get working, and their latest change with the flatfile introduces some really rough and unintuitive expressions related to the ignores keyword: https://github.com/eslint/eslint/issues/17400

If this is the direction eslint is going, I don't want to use it anymore. Especially when there are suitable alternatives around.

This change is open for discussion before merging. Some key points:

  1. Biome is supposedly faster. Not sure how much that matters for a linter + formatter, but whatever
  2. Biome is relatively new compared to eslint, which has been around since the dinosaurs. As such, the biome ecosystem is not built-up yet. Namely, there's an eslint plugin that verifies SolidJS code (https://github.com/solidjs-community/eslint-plugin-solid). I would have loved to use it, however it appears that the new eslint flatfile format confuses it. I still have yet to try the solid plugin with the old format since it seems to be the most compatible with the older format, however typescript-eslint seems to have already moved to the new flatfile format, stating that the previous format is deprecated.

Also this PR includes a change from the main branch that I forgot to push before creating this branch. Whoops.

bdotsamir commented 2 months ago

I almost forgot to mention: Biome is working on a solid plugin, and I'm subscribed to the issue: https://github.com/biomejs/biome/issues/2438

JackDotJS commented 2 months ago

definitely interested in this, eslint is kinda annoying for me to use too. i also like this part:

Biome is designed from the start to be used interactively within an editor

that said, i wonder if we should wait until the solidjs rules are implemented

bdotsamir commented 2 months ago

rebased

JackDotJS commented 2 months ago

rebased

and mergepilled