search

JackDotJS / vector-bot

A Discord bot for advanced moderation and server management.
https://discord.gg/s5nQBxFPp2
MIT License
15 stars 3 forks source link

Move away from node-fetch #10

Open bdotsamir opened 2 years ago

bdotsamir commented 2 years ago

Node 18 now has support for the browser fetch() method. It's also an LTS release, so we can rely on there being plenty of bug fixes and backported features for years to come.

RobertRR11 commented 2 years ago

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

bdotsamir commented 2 years ago

Sweet, ty. The current plan is to finish up #4- jack and I are on a call rn- then we'll tackle this one. But it's good to know that removing the node-fetch package is all it takes

JackDotJS commented 2 years ago

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

lol that's what i figured x)

JackDotJS commented 2 years ago

jack and I are on a call rn

@RobertRR11 if you wanna join the call by any chance lmk

RobertRR11 commented 2 years ago

sure @JackDotJS