JackDotJS / vector-bot

A Discord bot for advanced moderation and server management.
https://discord.gg/s5nQBxFPp2
MIT License
15 stars 3 forks source link

update discord.js to v13.7.0 #8

Closed RobertRR11 closed 2 years ago

RobertRR11 commented 2 years ago

Changes between v13.1.0 and v13.7.0 include:

All changes have been tested.

bdotsamir commented 2 years ago

I remember having to make these changes in my own bots. Robert, were the only breaking changes between 13.1 and 13.7 the MessageEmbed#setIcon & setFooter methods? I seem to recall there being something else.

RobertRR11 commented 2 years ago

There were breaking changes related to slash commands between 13.6 and 13.7, but that's not a problem since the bot doesn't use them yet. I don't know of any other than the ones I've already fixed in this commit. I have also tested the bot after this dependency bump and found no issues.

JackDotJS commented 2 years ago

There were breaking changes related to slash commands between 13.6 and 13.7, but that's not a problem since the bot doesn't use them yet.

uh, do you mean the bot doesn't use anything related to the breaking changes, or that the bot doesn't use slash commands? because if you mean the latter, that's completely false.

https://github.com/JackDotJS/vector-bot/blob/dev/vmodules/events/interaction.js

https://github.com/JackDotJS/vector-bot/tree/dev/vmodules/commands

JackDotJS commented 2 years ago

other than that, i see nothing wrong with this pr so i'll go ahead and merge it

RobertRR11 commented 2 years ago

uh, do you mean the bot doesn't use anything related to the breaking changes, or that the bot doesn't use slash commands? because if you mean the latter, that's completely false.

didn't notice that, but it looks like it doesn't use anything related to breaking changes