JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Container action is only supported on linux #12

Closed sayyid5416 closed 3 years ago

sayyid5416 commented 3 years ago
name: Pyinstaller

on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

jobs:
  build:

    runs-on: windows-latest

    steps:
    - uses: actions/checkout@v2

    - name: Package Application
      uses: JackMcKew/pyinstaller-action-windows@main
      with:
        path: src

image

Check action here: https://github.com/hussain5416/pyinstaller-example/actions

JackMcKew commented 3 years ago

I take it this was solved?

sayyid5416 commented 3 years ago

@JackMcKew I don't understand, what the problem was, but after changing my .yml file. Problem got solved. New yml:

name: Pyinstaller

on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: PyInstaller Windows
      uses: JackMcKew/pyinstaller-action-windows@main
      with:
        path: src

    - uses: actions/upload-artifact@v2
      with:
        name: Links extractor
        path: src/dist/windows # or path/to/artifact
JackMcKew commented 3 years ago

Oh right, the action runs in ubuntu but packages for windows

The old action was trying to run inside a windows github action and that's why it failed

sayyid5416 commented 3 years ago

@JackMcKew That's ironic and confusing for people new to this action, repo name is pyinstaller-action-**windows** and it runs on ubuntu

JackMcKew commented 3 years ago

The name is the intended target for the packaged application, I can appreciate the confusion though, hence why there is also pyinstaller-action-linux which packages for linux

sayyid5416 commented 3 years ago

Yes, but can you tell, why run on ubuntuand not on windows?

JackMcKew commented 3 years ago

Github actions are made in either Javascript or Docker, this repo is essential this repo modified for use with Github actions https://github.com/cdrx/docker-pyinstaller.

I think it would be a LOT harder to make use of the windows platform target in Github actions but I'm open to be proven wrong

sayyid5416 commented 3 years ago

OK, Thanks for the info, appreciate it.