JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Microsoft Visual C++ 14.0 or greater is required #17

Closed vtgdias closed 1 year ago

vtgdias commented 2 years ago

I receive the following error from github actions output (using pyinstaller-action-windows)

error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
----------------------------------------
ERROR: Failed building wheel for python-pkcs11

I am using python-pkcs11 library to build my binary, but it seems it needs Microsoft Visual C++ 14 or greater!

Is it possible to use Qemu with Microsoft Visual C++ 14 or greater?

JackMcKew commented 2 years ago

It seems like the solution to this may involve creating another docker image to run the code inside :(

MarketingPip commented 2 years ago

@JackMcKew He could also modify the docker image - https://github.com/cdrx/docker-pyinstaller to include the libraries he needs directly! And make changes to this action to use his custom docker with his library support.

Tho I do think some thing's need updated on this current action before using it & would advise finding another solution to build your exe in the meantime till kinks are worked out with this action! @vtgdias

vtgdias commented 2 years ago

Tks @MarketingPip, i am trying to use a self hosted runner for now!

On Thu, Mar 10, 2022 at 7:00 PM MarketingPip @.***> wrote:

@JackMcKew https://github.com/JackMcKew He could also modify the docker image - https://github.com/cdrx/docker-pyinstaller to include the libraries he needs directly! And make changes to this action to use his custom docker with his library support.

Tho I do think some thing's need updated on this current action before using it & would advise finding another solution to build your exe in the meantime till kinks are worked out with this action! @vtgdias https://github.com/vtgdias

— Reply to this email directly, view it on GitHub https://github.com/JackMcKew/pyinstaller-action-windows/issues/17#issuecomment-1064544466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2CM3FCIDVHBBKLN36AG3U7JWI3ANCNFSM5GAQJBWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Atenciosamente, Vinicius T. G. Dias

"A password should be like a toothbrush. Use it every day; change it regularly; and DON'T share it with friends" - USENET ''The quieter you become, the more you are able to hear "When mountains speak, wise men listen" - John Muir

MarketingPip commented 2 years ago

@vtgdias You're welcome! If you need any help with doing this please leave an issue on any of my random public repos - lol. I'll be glad to help!

Ps; if you do happen to write an option for providing custom library support for that docker image if they don't have this done (maybe add a commit for the community to use if willing!)

In the meantime tho I think you can go ahead with closing this issue (since this ultimately isn't an issue with the action - but the docker that powers it).

And if library support is added in future for those container(s) - the owner of this repo can add notes to documentation on how to use or link to docker container documentation itself.

TLDR - for other users reading this - as of March 11, 2022 this action CURRENTLY doesn't support custom libraries that might be needed to freeze your code

MarketingPip commented 2 years ago

@vtgdias - apologizes for just seeing this now as well. It appears that docker container is already set up to use your own defined libraries. See link below for documentation on how to do this!

How do I install system libraries or dependencies that my Python packages need?

@JackMcKew - possibly an if statement could be provided to install libraries / dependencies on the docker image in this action?

JackMcKew commented 2 years ago

PRs are more than welcome :)

The potential solution for these problems would be to run an eval statement in the entrypoint as provided from a variable in the action

I unfortunately don't have the time to implement this currently, but that's the first step I would take

MarketingPip commented 2 years ago

@JackMcKew - I added you to a repo to further discuss this project the other day so we can avoid blowing discussion up in here!

JackMcKew commented 2 years ago

@MarketingPip Please email me at jackmckew2@gmail.com for any separate discussion

PS, the invitation came through but didn't work

vtgdias commented 2 years ago

@JackMcKew/pyinstaller-action-windows @.***>

Think i don't have the skill set needed for this, but I'll try it anyway. tks

On Sun, Mar 13, 2022 at 8:17 PM Jack McKew @.***> wrote:

PRs are more than welcome :)

The potential solution for these problems would be to run an eval statement in the entrypoint as provided from a variable in the action

I unfortunately don't have the time to implement this currently, but that's the first step I would take

— Reply to this email directly, view it on GitHub https://github.com/JackMcKew/pyinstaller-action-windows/issues/17#issuecomment-1066203712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2CM4IRFKYPD2SJXIFRWTU7ZZP5ANCNFSM5GAQJBWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Atenciosamente, Vinicius T. G. Dias

"A password should be like a toothbrush. Use it every day; change it regularly; and DON'T share it with friends" - USENET ''The quieter you become, the more you are able to hear "When mountains speak, wise men listen" - John Muir

MarketingPip commented 2 years ago

@vtgdias - I think he was referring to me (anybody in general willing). But if you happen to take a jab at editing this action with success. Send a pull request!

Or - refer to the documentation I linked above to provide a solution for your problem in the mean time.

Ps; best way to learn is trial & error! :)

vtgdias commented 1 year ago

Tks @MarketingPip, I'll give it a try!

best regards,

On Sat, Mar 12, 2022 at 7:16 PM MarketingPip @.***> wrote:

@vtgdias https://github.com/vtgdias - apologizes for just seeing this now as well. It appears that docker container is already set up to use your own defined libraries. See link below for documentation on how to do this!

How do I install system libraries or dependencies that my Python packages need? https://github.com/cdrx/docker-pyinstaller#how-do-i-install-system-libraries-or-dependencies-that-my-python-packages-need

@JackMcKew https://github.com/JackMcKew - possibly an if statement could be provided to install libraries / dependencies on the docker image in this action?

— Reply to this email directly, view it on GitHub https://github.com/JackMcKew/pyinstaller-action-windows/issues/17#issuecomment-1065974437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2CM4AJXX7GPIGBYT2EYLU7UJSPANCNFSM5GAQJBWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Atenciosamente, Vinicius T. G. Dias

"A password should be like a toothbrush. Use it every day; change it regularly; and DON'T share it with friends" - USENET ''The quieter you become, the more you are able to hear "When mountains speak, wise men listen" - John Muir

JackMcKew commented 1 year ago

Can you please try the solution in the thread: https://github.com/JackMcKew/pyinstaller-action-windows/issues/34