JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Choose Python version #19

Closed flolbr closed 1 year ago

flolbr commented 2 years ago

Is there any way to easily specify the python version that will be used by the action ?

JackMcKew commented 2 years ago

Potentially you could pass an ARG to the base dockerfile to change the python/pyinstaller version

Souce dockerfile that is used by this project: https://hub.docker.com/r/cdrx/pyinstaller-windows

squigjess commented 2 years ago

Potentially you could pass an ARG to the base dockerfile

I'm not too familiar with GitHub workflows; how would one accomplish this?

FlorianCassayre commented 2 years ago

I'm confused as well; could you be more specific? Thanks in advance.

sayyid5416 commented 2 years ago

Yes, it is a serious issue, since action is failing because of different python versions.

image

JackMcKew commented 2 years ago

Unfortunately to set the python version through an ARG would include building the new image and pushing it somewhere else (ie, docker hub), so this might be a bit tricky

The way official python dockerfiles are to be built for each and every version which is out of the scope of this project

JackMcKew commented 2 years ago

The potential solution for this might be by running certain steps in bash to implement the different versions of Python: https://github.com/JackMcKew/pyinstaller-action-windows/issues/17

JackMcKew commented 1 year ago

Please try this: https://github.com/JackMcKew/pyinstaller-action-windows/issues/34