search

JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
173 stars 71 forks source link

SPEC file name set and upgrade some setuptools "pip wheel setuptools" #2

Closed biplobsd closed 4 years ago

JackMcKew commented 4 years ago

Hi @biplobsd ,

Thank you so much for the pull request! Great idea as well.

Could I please ask that you also update the README to reflect this new setting as this may trip new users up.

My only concern is that a default of pyinstaller.spec may not be the case for every user, could we also run a check to see if the specified .spec is within the path directory, if not warn the user and run as is where it takes whatever .spec it can find.

biplobsd commented 4 years ago

Hey i changed *.spec as default. Progrom behavior as same as before! If anyone can set spec path he can do!. I also tested some. if you want to see https://github.com/biplobsd/pyinstaller-action-windows-example

JackMcKew commented 4 years ago

Awesome thank you so much, this will be much friendlier to new users I hope!

biplobsd commented 4 years ago

@JackMcKew I also thanks you for accepted my commits. Yes new user if look source file they easily figure out what is going on. Same as me. 🙂