JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Support for tkinter #27

Closed danieliser closed 5 months ago

danieliser commented 2 years ago

I saw the linux version had support for it, wondering if the Windows version could do that as well?

JackMcKew commented 2 years ago

G'day mate,

Have you got a specific error of tkinter not working on Windows?

danieliser commented 2 years ago

No I’m trying to use the actions to build windows exe files on change to main branch, but it fails to build without tkinter installed and from what I can tell I can’t use requirements.txt to install it like normal packages. At least I got errors when I tried.

that led me to find you specific action that also installed tkinter, but that is on Linux and won’t handle building Windows .exe from my testing.

danieliser commented 2 years ago

352AEE97-9B23-49ED-8645-74932CA288BC

JackMcKew commented 1 year ago

Can you please provide a reproducible example?

ego-lay-atman-bay commented 1 year ago

The package name for tkinter is actually tk. You need to replace

tkinter==8.6

with

tk==8.6

in the requirements.txt

Mattherix commented 1 year ago
tk==8.6

in the requirements.txt

Tk stands for TensorKit. It's a small library for deep learning.

You can't install tkinter using pip.

chrisdeely commented 1 year ago

I believe tkinter is part of the Python distribution and as such should not be listed in the requirements.txt. The error shown above is because the package does not exist in pip so the installation fails.