search

JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Upgrade pyinstaller 5.3 -> 5.13 #42

Closed GaNiziolek closed 5 months ago

GaNiziolek commented 7 months ago

The 5.3 version is old (2022-07-30) and doesn't have many of the recent hooks configs, I was having an issue with this version with pydantic=2.0.0, and was able to resolve this by upgrading pyinstaller to 5.13 since they contain most recent hooks.

To upgrade I just changed the PYINSTALLER_VERSION arg on dockerfile, then built and pushed to dockerhub to my image ganiziolek/pyinstaller-windows:3.10. Maybe you want to pull and tag with your name and push it to your docker hub.

Also, I am creating this PR on the python3-10-pyinstaller-5-3 branch, maybe you should create a python3-10-pyinstaller-5-13 branch, which is more appropriate.

JackMcKew commented 5 months ago

Hey! Would you mind reopening this against main and we can get it merged in? :)