search

JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Build will succeed but exe will fail to start due to ModuleNotFoundError pkg_resources.extern #51

Closed rvbg closed 2 months ago

rvbg commented 3 months ago

Building an application with the current main version will succeed, but the application will not be able to run, due to ModuleNotFoundError: No module named 'pkg_resources.extern'.

This issue has been discussed and fixed here:

pyinstaller/pyinstaller#8554

Adding --hiddenimport pkg_resources.extern or hiddenimports=['pkg_resources.extern'], to the .spec file is enough to fix this with the old pyinstaller version used in this action.

JackMcKew commented 3 months ago

What do you suggest is the fix for this? Adding documentation to say this is a fix, or upgrading the installer version?

rvbg commented 3 months ago

Bumping the pyinstaller version to >=6.7 should be the best, due to the big breaking impact on literally all projects. Adding few lines to the documentation can't hurt in the meantime :smiley: .

JackMcKew commented 3 months ago

Would you like to create a PR for the documentation and I'll add it to my to do to create another docker image with the latest version

rvbg commented 3 months ago

Sure, I will create a PR as fast as possible.

JackMcKew commented 3 months ago

I'm going to leave this issue open until I get around to creating a new dockerfile

axu2 commented 2 months ago

Looking forward to a new docker image, subscribing to this issue^. No rush though.

JackMcKew commented 2 months ago

I've updated the docker image, thank you for reminding me!