search

JackMcKew / pyinstaller-action-windows

Github Action for building executables with Pyinstaller
MIT License
168 stars 67 forks source link

Possible issue with sub folders in src #6

Closed stefanino-ch closed 3 years ago

stefanino-ch commented 3 years ago

Little test project go get familar with Github Actions: working

Here in everything works fine.

If the main py file is in a subfolder in src: not-working

pyinstaller seems to work fine as github action, no error messages are displayed, BUT no artifacts are created and the following upload reports a warning: warning-message

On the local file system itself, such a configuration is perfectly working, the installers are created.

Not sure if this is really something which can/ must be fixed. But at least a little warning in the action explanation on the github page would be appreciated.

JackMcKew commented 3 years ago

Hey! Thanks for raising this

What was the resulting path of the installer when you ran it locally? I'd take a guess and say that the upload path needs to be altered to match

stefanino-ch commented 3 years ago

Yep, classic PIBCAK issue. If the path for the upload is set correctly all is working fine. solution

I was somehow under the impression the upload path would be the one where the file ends up after copying, nop this is the source path. Sorry about.

JackMcKew commented 3 years ago

Awesome! Thank you for using the action ☺️