JackStat / ModelMetrics

Rapid Calculation of Model Metrics
29 stars 9 forks source link

tnr_ using same cutoff as confusionMatrix_ #33

Open labrax opened 3 years ago

labrax commented 3 years ago

Hi Tyler,

Hope you are doing well. Thanks for this great package.

On https://github.com/JackStat/ModelMetrics/blob/master/src/confusionMatrix_.cpp:

I suggest to standardise it using confusionMatrix_, as in the attached patch.

I am not fully aware, but I strongly suggest checking the functions mcc_ and kappa_ as they might have a different result due to the different way it is calculated.

Best wishes, Victor

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 56.429% when pulling 8230b81c6cb31e129772f6e54e663e93f8c621c9 on labrax:master into d3cbb5f1004180aef85ce27d94b3112c136aee69 on JackStat:master.