search

Jackhammer9 / RedDownloader

A python library to simplify downloading different types of media from reddit
GNU General Public License v3.0
79 stars 14 forks source link

A problem with YouTube downloads #31

Closed dylnbk closed 1 year ago

dylnbk commented 1 year ago

Type Detected: Youtube Video Downloading Youtube Video

Connection Error [WinError 2] The filename, directory name, or volume label syntax is incorrect: 'Youtube title | Youtube title | Youtube title.mp4' -> '72ac10ad93a340d5ac09ea45f7bde5b3.mp4'

I believe using the YouTube title as the file name is causing an error due to the naming convention.

Could this perhaps be updated?

stream.download('.') & stream.download(self.destination) can take a filename= argument.

Pytube also has a helper function safe_filename().

Jackhammer9 commented 1 year ago

Thanks For highlighting this issue to me, it has been patched in #33