search

Jackie-Chou / MC-CNN-python

a python implementation of MC-CNN
MIT License
48 stars 19 forks source link

Image Standardization #8

Closed BenJanes-Sechoia closed 2 years ago

BenJanes-Sechoia commented 2 years ago

Hi, I noticed that the image standardization in datagenerator.py prefetch is different from the implementation in match.py. I believe the way it's done in match.py is the correct one. I don't think the image should be divided by 255 before subtracting the mean and dividing by the standard deviation. I'd imagine this would impact performance quite a bit if the image standardization is different in training compared to testing?

BenJanes-Sechoia commented 2 years ago

I made a mistake, the image standardization achieves the same results regardless of the divide by 255, so doesn't impact performance at all.