search

Jacksaur / Gorgeous-GRUB

Collection of decent Community-made GRUB themes. Contributions welcome!
1.22k stars 24 forks source link

Different way to associate labels with images: <br> #3

Closed edsantiago closed 2 years ago

edsantiago commented 2 years ago

I had forgotten about github's alternating-color table rows. This attempts to preserve alternating-shading rows by keeping the label in the same row element as the thumbnail, split by an html \
. I find the markdown much less readable, hence less maintainable, but the resulting rendering is a little cleaner IMO.

Signed-off-by: Ed Santiago ed@edsantiago.com

edsantiago commented 2 years ago

Sorry for the barrage. This is the result of a small perl script that combined the rows together: image, <br/>, [link].... I automated it because it was too fragile to do manually. You can preview the result on my branch, and see how the alternate-shadings are a different way to associate links with images.

But yeah, it's clunkier to add and maintain entries. Your call - I won't be upset if you reject. Thank you again for this collection!

Jacksaur commented 2 years ago

It is a decent improvement, but I think I prefer the separated labels for now, keeps them all aligned no matter the image height. Plus I'd rather keep the table markdown simpler as I don't have any proper program or tool to edit it easily right now.

No need to apologize for the PRs either! This is my first project that's gained some attention, and I'm always happy to see improvements offered by others :)