search

Jacksgong / JKeyboardPanelSwitch

For resolve the layout conflict when keybord & panel are switching (Android键盘面板冲突 布局闪动处理方案)
Apache License 2.0
4.18k stars 684 forks source link

lishouxian first pull request #31

Closed sollian closed 8 years ago

Jacksgong commented 8 years ago

感谢你的PR，很nice的修改，不过需要做以下规范的调整:

  1. 切到feature分支
  2. 扫一扫lint。
  3. 通过 git rebase -i修改 commit message为 AngularJS's commit message convention

任何问题，保持交流，如果始终存在疑惑，交流起来麻烦直接来这里交流: https://gitter.im/Jacksgong/JKeyboardPanelSwitch

Jacksgong commented 8 years ago

HI, 我看到你提交了修改，不过commit message并不规范。需要通过 git rebase -i修改 commit message为 AngularJS's commit message convention。

任何问题，保持交流，如果始终存在疑惑，交流起来麻烦直接来这里交流: https://gitter.im/Jacksgong/JKeyboardPanelSwitch

Jacksgong commented 8 years ago

转而维护这个PR