search

JacksonBates / fcc-scraper

A web scraping tool to allow freeCodeCamp campers to download their solutions.
https://freecodecamp-solutions.herokuapp.com
29 stars 3 forks source link

updated regex #16

Closed mrslwiseman closed 7 years ago

mrslwiseman commented 7 years ago

Hey jackson. Even though ive used git quite a bit, this is my first pull request! actually something that I felt I could help with for once yay!

I've tested this, all file names are looking first class.

Not sure why all the line returns come up as a change ? I didnt touch them.

JacksonBates commented 7 years ago

Thanks, Matt. I'll take a proper look this evening.

JacksonBates commented 7 years ago

fixes #7

mrslwiseman commented 7 years ago

cool that was a good feeling contributing. I helped make a thing! yes I wondered what was going on there with index.js file...

On 12 Nov. 2017 8:33 pm, "Jackson Bates" notifications@github.com wrote:

fixes #7 https://github.com/JacksonBates/fcc-scraper/issues/7

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JacksonBates/fcc-scraper/pull/16#issuecomment-343724353, or mute the thread https://github.com/notifications/unsubscribe-auth/ATw-XCpg8Aph7m6KMO4siZM5dfxfh6-Rks5s1rt9gaJpZM4QaLRB .

mrslwiseman commented 7 years ago

yeah it must be prettify doing that...

On 12 Nov. 2017 11:56 pm, "matthew wiseman" mrslwiseman@gmail.com wrote:

cool that was a good feeling contributing. I helped make a thing! yes I wondered what was going on there with index.js file...

On 12 Nov. 2017 8:33 pm, "Jackson Bates" notifications@github.com wrote:

fixes #7 https://github.com/JacksonBates/fcc-scraper/issues/7

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JacksonBates/fcc-scraper/pull/16#issuecomment-343724353, or mute the thread https://github.com/notifications/unsubscribe-auth/ATw-XCpg8Aph7m6KMO4siZM5dfxfh6-Rks5s1rt9gaJpZM4QaLRB .