nus-pe-bot
commented
2 years ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Past time can be added as appointment
app 1 dt/16-04-2022 02:20 at/skfjkh jksdhfPast time of today can be added as an appointment even if the time has passed.
[original: nus-cs2103-AY2122S2/pe-interim#854] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for the review.
This feature is actually intended. We only restrict adding past dates, which means anytime today is still possible.
The reason for this is pets may have last-minute appointments on the day itself and the pet daycare owners might only key it in the system later in the day.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: The user might want to make an appointment on tomorrow morning but wrongly keyed in the time to today, the time can still be added in, where in fact an error should be thrown. As you said in your reply 'pet daycare owners might only key it in the system later in the day', then by this logic the pet owner can key in the system days later for record keeping purposes, the meaning of appointment suggests a time in the future, we cannot make an appointment in the past.
Steps to reproduce: app 2 dt/16-04-2022 09:30 at/nus clinic When reproducing, change the date to the current date and time to the time earlier than now.
Expected result: Notify me that the time I have entered is in the past, since it is currently afternoon of 16th April, I should not be making an appointment in today's morning.
Actual result: An appointment is added successfully.