search

JackyXu-Cool / Team-2130-Machine-Learning-Roulette

Georgia Tech Junior Design Project
8 stars 5 forks source link

Added test for naive bayes #41

Closed lhyelinn closed 1 year ago

lhyelinn commented 1 year ago

Added tests for naive_bayes()

Timiport commented 1 year ago

Good Work! This LGTM.

ruokun-niu commented 1 year ago

Quick question: Is there a need to modify the NB function so that it accepts a random seed? Just curious as I'm not really familiar with NB

lhyelinn commented 1 year ago

Quick question: Is there a need to modify the NB function so that it accepts a random seed? Just curious as I'm not really familiar with NB

Yes, we can include random seed as part of separating the dataset into training set and testing set. Since this is not necessary in all case of naive bayes, I modified the code to use random seed only when it's given.

ruokun-niu commented 1 year ago

Naisu! Approved!