search

Jackysi / advancedtomato

AdvancedTomato firmware repository (Tomato by Shibby fork)
https://advancedtomato.com/
Other
279 stars 71 forks source link

dnsmasq custom configuration limited to 2048 characters ? #443

Closed zjgithub closed 4 years ago

zjgithub commented 4 years ago

Firstly thank you all for the great works.

I flashed Asus RT-AC68U (RT-AC68U-AT-ARM-3.5-140-AIO-64K.trx) without problem, but when it comes to adding customer configuration for dnsmasq, the webui gives error saying "limited to 2048 characters".

I hope this bug can be fixed in next build, because dnsmaq is very powerful and 2048 character limit seems really limiting its potential.

Thank you !

rampageX commented 4 years ago

dnsmasq webui just need one line: conf-dir=/opt/etc/dnsmasq/custom/

Then put all your custom config files of dnsmasq into /opt/etc/dnsmasq/custom/, no limited.

zjgithub commented 4 years ago

That's wonderful ! Thank you !

On Thu, Dec 12, 2019 at 10:26 AM rampageX notifications@github.com wrote:

dnsmasq webui just need one line: conf-dir=/opt/etc/dnsmasq/custom/

Then put all your custom config files of dnsmasq into /opt/etc/dnsmasq/custom/, no limited.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Jackysi/advancedtomato/issues/443?email_source=notifications&email_token=AA6NXS2PLVPCCLIZSIQ3WBTQYJ63TA5CNFSM4J2BUFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXSKOA#issuecomment-565126456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6NXSZE2J66PWYNZ237RZLQYJ63TANCNFSM4J2BUFGQ .

Jackysi commented 4 years ago

That is the best solution. Config limitation to 2048 lines is actually huge. The config is stored in NVRAM which is limited in size and when nvram gets full, it starts dumping out good data. I would say 2048 is safe and high limit, for extras use file system.