Assets/Scripts/Logic - Githubissues

Jacob-Brosler / TRPG

A TRPG/RPG hybrid, this game combines the massive, open, living and breathing overworld of a traditional RPG with the battle system of a tactical RPG

0 stars 0 forks source link

Assets/Scripts/Logic #4

Open EthanNichols opened 4 years ago

EthanNichols commented 4 years ago

Questionable

Pair.cs & Triple.cs The point of Tuples are that they are immutable data. If you need to be able to change and edit the values, just create a class/struct with those types. Also, for example, it makes more sense to call tileEffect.effects rather than tileEffect.second

Other

I'll ignore reviewing Graph.cs since it has no reason to exist.