Jacob-Stevens-Haas / gen-experiments

Pysindy experiments. Composable and extensible
MIT License
1 stars 2 forks source link

Combine grid_vals, grid_params, grid_decisions together #23

Open Jacob-Stevens-Haas opened 5 months ago

Jacob-Stevens-Haas commented 5 months ago

Grid vals/params/decisions

It's silly that these are separate. Current implementation is that they're ordered so they can align and zip, but there's a lot of code to use one to identify values of the other like:

        plot_params = [
            param
            for decide, param in zip(grid_decisions, grid_params)
            if decide == "plot"
        ]

Proposals:

Series data

Series data is difficult to navigate through in code, because (a) which plot/grid axis is which element of the SeriesData list is unclear (b) instead of a named tuple, we have an Annotated tuple of "metrics" and "arg_opts" inside

Jacob-Stevens-Haas commented 5 months ago

Standardizing this will also make it easier to find gridpoints based upon plot params or grid params