search

Jacob-Stevens-Haas / gen-experiments

Pysindy experiments. Composable and extensible
MIT License
1 stars 2 forks source link

Disable abs -> rel noise conversion #24

Closed Jacob-Stevens-Haas closed 7 months ago

Jacob-Stevens-Haas commented 7 months ago

This change clarifies the transition of grid params (every parameter used in all series that varies in the gridsearch) to scan params (only those that remain after argmax/argmin) to finally, plot params (those that go into final plots). Given the removal of the ability to convert parameters after experiments, plot params are the same as scan params until that feature is re-enabled.

This also fixes the issue with different gridpoints using different simulations; thanks @yb6599 for spotting this.

To use the new branch, change the grid_vals and grid_params to use "sim_params.rel_noise" instead of absolute noise.

ALSO - unrelated, but can you add unbias=True in the MIOSR optimizer used?

Jacob-Stevens-Haas commented 7 months ago

This branch should work to queue experiments; the only issues are with static typing and python 3.10

yb6599 commented 7 months ago

ALSO - unrelated, but can you add unbias=True in the MIOSR optimizer used?

Is this supposed to be added in config?

LGTM.

Jacob-Stevens-Haas commented 7 months ago

Is this supposed to be added in config?

Yeah, you'll have to add it to an opt_params, and thus to a other_params