JacobEvelyn / friends

Spend time with the people you care about. Introvert-tested. Extrovert-approved.
MIT License
872 stars 39 forks source link

Fix for the case of add tag or add nickname args are nill #266

Closed m-t-a-n-a-k-a closed 4 years ago

m-t-a-n-a-k-a commented 4 years ago

close #265

I'm not sure if this is the best fix in terms of where throwing exceptions. Please tell me your opinion🙏 Thank you.


Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we merge this change:

Don't worry—this list will get checked off in no time!

codecov[bot] commented 4 years ago

Codecov Report

Merging #266 into main will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          24       24           
  Lines         755      757    +2     
=======================================
+ Hits          743      745    +2     
  Misses         12       12           
Impacted Files Coverage Δ
lib/friends/commands/add.rb 100.00% <100.00%> (ø)
lib/friends/introvert.rb 98.70% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a99a04...e57b1fb. Read the comment docs.

JacobEvelyn commented 4 years ago

Thank you, @m-t-a-n-a-k-a! This change is now released in version 0.53!