search

JacobLinCool / LeetCode-Stats-Card

Show your dynamically generated LeetCode stats on your GitHub profile or your website!
https://leetcard.jacoblin.cool
MIT License
663 stars 82 forks source link

src/core/elements: Show the correct ranking #105

Closed Panchajanya1999 closed 1 year ago

Panchajanya1999 commented 1 year ago

Show the correct ranking

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 5f99e8c91e4a929848c9975ee4b7ba18e24a1e28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Panchajanya1999 commented 1 year ago

@JacobLinCool can you review and merge it please?

JacobLinCool commented 1 year ago

I believe the accurate ranking is not necessary for large ranks and sometimes make the displayed information too complex.

But I will still merge it and maybe add an option to use the current behavior later.

Thanks for your contribution!

Panchajanya1999 commented 1 year ago

I believe the accurate ranking is not necessary for large ranks and sometimes make the displayed information too complex.

But I will still merge it and maybe add an option to use the current behavior later.

Thanks for your contribution!

thank you for merging. I have an idea - What about adding a comma in between the numbers? Like - #123456 looks better when it is #123,456.

I am planning to implement it but sadly i cant start the server. Do you have a Telegram account so that we can discuss on it? My TG username is - @panchajanya1999 on TG too.

Thank You!