JacobPfau / procgenAISC

MIT License
18 stars 16 forks source link

Fix installing from pip by adding setup requirements. #3

Closed PavelCz closed 2 years ago

PavelCz commented 2 years ago

As can be seen here, procgen requires gym3 during build. Now you might think that's no problem since gym3 is in the dependencies, but these dependencies are actually installed after the build. When moving the gym3 requirement into the setup_requires dependencies, this change allows people to directly install procgen using e.g. pip like so: pip install "procgen @ git+https://github.com/JacobPfau/procgenAISC.git", without needing to manually install gym3 before or something like that.

PavelCz commented 2 years ago

@langosco This could be potentially helpful for people using procgen in their requirements.