Should we be explicitly building `ConceptChunk`s when making `UnitalChunk`s or letting the constructors do it implicitly?

[samm82]

This issue was migrated from #3199 and will be updated upon its completion. It makes #3074 obsolete.

---

We have constructors that build a UnitalChunk from a Concept c and constructors that build it from "a given 'UID', term, and definition". It definitely makes sense to have constructors of the first type (since some concepts are reused independently of their UnitalChunk versions, but I'm not sure if we should keep the constructors that implicitly build a Concept from its parts. It might be good to force the user to create the Concept explicitly to encourage reuse, support future change, and make code less cluttered, but it also means that information is more spread out. These implications are similar to those discussed in the wiki page for the DefinedQuantityDict chunk investigation. Since ucs (which builds from the parts of a Concept) is used in cuc', we would potentially need to tweak it as well.

https://github.com/JacquesCarette/Drasil/blob/09365d7d1f5dc9b54e84a8d64cb601184456ea0c/code/drasil-lang/lib/Language/Drasil/Chunk/Constrained.hs#L125-L130

Alternatively, we could also move one of these sets of constructors to drasil-utils.

[JacquesCarette]

As discussed at the meeting, this is part of a bigger design question. A Unital is really an instance of its underlying Concept; so the Concept should be "by reference" instead of being contained.

Can you please add (or point me to if it already exists) a list of all the calls to cuc' to see what they "really are"?

[balacij]

Because I'm interested in the bigger design question as it relates to the theory lattice I'm interested in...

λ ~/Programming/MyDrasil/code/ master* rg "cuc' " -ths
drasil-lang/lib/Language/Drasil/Chunk/UncertainQuantity.hs
120:uqc nam trm desc sym un space cs val = uq (cuc' nam trm desc sym un space cs val)
125:uqcND nam trm sym un space cs val = uq (cuc' nam trm "" sym un space cs val)

drasil-lang/lib/Language/Drasil/Chunk/Constrained.hs
68:-- | Creates a constrained unitary chunk from a 'UID', term ('NP'), 'Symbol', 'Space', 'Constraint's, and a 'Maybe' 'Expr' (Similar to 'cuc' but no units).
126:cuc' :: (IsUnit u) => String -> NP -> String -> Symbol -> u
128:cuc' nam trm desc sym un space cs rv =

drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs
185:pendDisAngle = cuc' "pendDisAngle"

drasil-example/swhs/lib/Drasil/SWHS/Unitals.hs
415:tempW = cuc' "tempW"
422:tempPCM = cuc' "tempPCM"
429:watE = cuc' "watE" (nounPhraseSP "change in heat energy in the water")
435:pcmE = cuc' "pcmE" (nounPhraseSP "change in heat energy in the PCM")

https://github.com/JacquesCarette/Drasil/blob/e4b3354f1d8586ff25fec845ea9618af4bff25fe/code/drasil-lang/lib/Language/Drasil/Chunk/UncertainQuantity.hs#L116-L125

https://github.com/JacquesCarette/Drasil/blob/e4b3354f1d8586ff25fec845ea9618af4bff25fe/code/drasil-example/dblpendulum/lib/Drasil/DblPendulum/Unitals.hs#L184-L189

https://github.com/JacquesCarette/Drasil/blob/e4b3354f1d8586ff25fec845ea9618af4bff25fe/code/drasil-example/swhs/lib/Drasil/SWHS/Unitals.hs#L414-L438

Aside: it's also funny: I've had a nagging feeling since #3134 that "smart constructors" might hide a lot of information. Here, I think they hide information from the chunk database, but I think it might also be related to the "conflicting UIDs" bubble (#2911 ?) because this, while it is an extension of the underlying Concept, it is also an instance. So, here, should they even be sharing the same UID?