Closed tingyuw closed 1 year ago
Comments:
Structurally, I like how the next parts are Background on Drasil and Jupyter, to make the Problem Statement understandable to the reader.
However, I did not review those parts, as the "1.0" part needs so much work, I think that needs to be fixed first. Because these other parts, 1.1 and 1.2, need to logically follow from the earlier parts, and make sense with it as a whole. Please fix this, and then ask again for a review.
If following the same structure that 1.1 is background on Drasil and Jupyter and 1.2 is the problem statement, would the first paragraph be like a quick summary of both background information and problems? You mentioned that the introduction should start with something like what are Jupyter notebooks, and since this information is presented in 1.1, I was wondering if a summary of them would make sense or the first paragraph should be something else. Or the contents should be structured differently (e.g., move 1.1 to the first paragraph?)
1.0 (i.e. what is before 1.1) should provide context and very high level ideas of what's coming. It's not a summary of 1.1 and 1.2, but rather a foreshadowing, to let the reader know they'll need the deeper details provided in 1.1 and 1.2 to really understand what your thesis is about.
@tingyuw we have some documents on writing on the se4sc repo, including a list of previous MEng report samples.
Would it make more sense if I start with an introduction of scientific computing and something like it requires time and effort for developing high quality software and documentation; Jupyter Notebook is an application for creating scientific computing documentation. What are the problems for writing the documentation manually, and how generative programming improves it, then get into 1.1 the introduction of Drasil?
It makes sense, but don't make that too long. Get to Jupyter quickly. It does make sense to have a proper description of Jupyter (what it is, who uses it, its growth) to show the relevance of your work.
Yes about problems for writing the documentation manually (with citations). The "generative programming improves it" is a claim that needs to be justified, and not a conclusion / fact. So it's part of the research itself. You can and still should talk about it, but using different words.
Do you have any suggested paper to read that talks about the problems of writing the documentation manually or just about the repetition work for developing scientific computing documentation in general? I found some that talks about the best practice for developing scientific software but do not cover much about why it's time-consuming and inefficient.
I don't, off the top of my head. I think there are papers by Diane Kelly that @smiths would know better, that do comment on that.
I did find some papers by Diane Kelly and also one that talks about the implementation challenges in ML documentation. I guess there are some similarities.
I have the updated version ready in Thesis. Please review chapter one. Thank you. @JacquesCarette @smiths
@tingyuw there are a few papers that discuss the challenges for writing scientific software. There are papers that discuss documentation being difficult, but I can't think of a paper that explicitly says it is repetitive. I'll mention some papers below. They can all be found in our pub repo in the References.bib file. I'll identify them by the same citation key as in the bib file.
Thank you @smiths! I'll check them out.
Comments on latest version of Ch.1:
@tingyuw, what is the status of Chapter 1? Have you incorporated the feedback from the above discussion?
@smiths I'm working on it! Will have it done today.
@smiths I have addressed the above feedback. The original link to my report should reflect the changes!
@tingyuw here is a review of Chapter 1 via a marked-up pdf file. Given that @JacquesCarette and I have both responded, I'm going to close this issue.
Feedbacks are incorporated in https://github.com/JacquesCarette/Drasil/commit/b4d6ef6fe7a1b04ff6da4ff8379650be6d356772.
Chapter 1 Introduction is ready for review. Please see the first chapter in Thesis. Please let me know what you think. Thank you!