search

JacquesCarette / Drasil

Generate all the things (focusing on research software)
https://jacquescarette.github.io/Drasil
BSD 2-Clause "Simplified" License
142 stars 26 forks source link

Wiki Workflow: Ensure all files have windows-friendly names #3793

Closed balacij closed 3 months ago

balacij commented 3 months ago

@daijingz is exhibiting an issue with #3705 regarding a "bad path name". He is using Windows and Git Desktop. I believe the "bad path name" is a result of Windows' file system having more restrictions on what valid file names are in comparison to Linux and Darwin. In other words, the current repo might be unusable for Windows users who don't use Linux on Windows (i.e., use Windows-native-build tooling).

This PR tries to:

  1. Fix existing issues (just one file name), and
  2. Restrict us from at least few common edge cases involving bad file names.

I don't think it is necessary to go all out and make sure that all file paths and names are valid in the git repo -- this PR does just the bare minimum.

@daijingz if you could please try out this branch and report if it works, that would be appreciated!

balacij commented 3 months ago

Ok, @B-rando1 and @samm82 tested this for me (testing breakage + fix) -- thank you guys again! So this fixes the path issue related to Windows machines cloning our repo.

JacquesCarette commented 3 months ago

There's a merge conflict to resolve first.

balacij commented 3 months ago

Good to go now!