search

JacquesCarette / Drasil

Generate all the things (focusing on research software)
https://jacquescarette.github.io/Drasil
BSD 2-Clause "Simplified" License
142 stars 26 forks source link

Use Stack LTS-associated HLint in Lint workflow #3803

Closed balacij closed 2 months ago

balacij commented 3 months ago

This should help with #3764 (assuming the CI passes in that PR).

Latest test: https://github.com/JacquesCarette/Drasil/actions/runs/9522582729/job/26252411306

This PR:

  1. Switches our tested HLint version (in our Lint.yaml workflow) to that shipped with our associated stackage release
  2. Extends the LTS updater script to automatically help with updating the HLint version in the Lint.yaml workflow too
balacij commented 3 months ago

Ok, don't merge this yet. I need to debug why the Linter workflow isn't running.

balacij commented 3 months ago

This one is ready for review -- disregarding my earlier comment (now marked as outdated) and the current "failure" of the current CI workflow. For the CI, please see the one I linked in the OP.

EDIT: Right after writing this comment, I realized that I had accidentally left in one 'testing' snippet of code that affixed the updater script to HLint v3.4.1, so I just had to force-push and cancel the CI again to conserve minutes and remove the testing code.

balacij commented 2 months ago

Thank you for syncing this with main, @JacquesCarette ! This one is good to go on my end.