I updated the function used by Java, C#, and C++ for listSlice, so listSlice should be consistent now between all 5 targets.
Design decisions:
If beg or end are not given, we find values for them in the same way
as with Swift.
We also have to generate the condition for the for-loop:
If step has a literal value, we use that to generate a one-sided
check: either step < end or step > end
If step does not have a literal value but beg and end do, then we
use that information to generate a single double-sided bounds check:
either beg < step < end or end < step < beg.
If step does not have a literal value, and beg or end doesn't
either, then we need to check both of the above double-sided checks.
I updated the function used by Java, C#, and C++ for
listSlice, solistSliceshould be consistent now between all 5 targets.Design decisions:
If
begorendare not given, we find values for them in the same way as with Swift.We also have to generate the condition for the
for-loop:stephas a literal value, we use that to generate a one-sided check: eitherstep < endorstep > endstepdoes not have a literal value butbegandenddo, then we use that information to generate a single double-sided bounds check: eitherbeg < step < endorend < step < beg.stepdoes not have a literal value, andbegorenddoesn't either, then we need to check both of the above double-sided checks.Closes #3809 Builds on #3820