JacquesCarette / Drasil

Generate all the things (focusing on research software)
https://jacquescarette.github.io/Drasil
BSD 2-Clause "Simplified" License
143 stars 26 forks source link

De-duplicate and fix rendering of Jupyter artifacts #3877

Open BilalM04 opened 3 months ago

BilalM04 commented 3 months ago

The current Jupyter printer (Language.Drasil.JSON.Print) is heavily duplicated, most of it being a direct copy paste of functions from Language.Drasil.HTML.Print. Duplicated functions should be imported rather than copied.

The Jupyter rendering also uses a lot of Hacky HTML rather than pure markdown, specifically tables. With the new Markdown printer, this hacky HTML should be removed by leveraging the new functions in the Markdown printer and helper. Additionally, several components in the Jupyter artifacts are just broken. For example, list indentation, expressions, and captions.

Goal: Fix broken components and reduce code duplication.

JacquesCarette commented 3 months ago

Agreed!