search

JacquesLucke / blender_vscode

Visual Studio Code extension for Blender development.
MIT License
572 stars 75 forks source link

Remove link to addon directory at exit of blender #55

Closed Celeborn2BeAlive closed 3 years ago

Celeborn2BeAlive commented 4 years ago

Currently the python code loaded by blender through the VS code extension creates a symlink from the blender addons folder to the source code of the addon opened in VS code.

This pull requests remove created symlinks in order to put back the addons folder of the user in its previous state.

You can reject the pull request if you think the symlink should stay in the addons folder. In my opinion the blender installation or user folder should not me modified after the debug session has ended.

One other thing I want to add is disabling the extension when blender exits in order to get a full cleanup. However I did not found a way to do that (here is a post I have opened to ask for information on that https://devtalk.blender.org/t/running-python-code-just-before-blender-exits/10803/2).

Btw, thank you for your work on this extension, it saves so much development time ! 👍

JacquesLucke commented 4 years ago

Thanks for the patch. I'm not sure if the symlink should be removed. I usually want to keep it, so that the addon is available when I start Blender separately..

What benefit do you have from this change? (Other then the fact that the addons folder is clean again)

Celeborn2BeAlive commented 4 years ago

In my case I prefer having a development phase that let the blender I'm debugging/experimenting on in the same state it was before. In a studio it can be useful because blender might be distributed on every user's computer by an automated process and we want to keep it in the same configuration for all users, included the blender distrib of developers, so they have the same blender as artists.

However I can totally understand you want to keep the extension like it is for the general user, with symlinks staying in blender's install. In that case don't worry, I will keep my modification in my fork :)

Mateusz-Grzelinski commented 2 months ago

actually, I like this feature.

What benefit do you have from this change? (Other then the fact that the addons folder is clean again)

I keep having broken links to my addons that then cause permission denied error, for example