search

Jacse / react-native-app-intro-slider

Simple and configurable app introduction slider for react native
MIT License
1.66k stars 330 forks source link

Change slide key from number to string #199

Closed jorjordandan closed 4 years ago

jorjordandan commented 4 years ago

Prevents warning -> "Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string. " from Flatlist data attribute. Avoids the warning for people copying code from the readme :)

jorjordandan commented 4 years ago

Further discussion here: https://github.com/facebook/react-native/issues/18291

Jacse commented 4 years ago

Could you update the examples as well?

jorjordandan commented 4 years ago

None of the examples use a number as a key prop - they use the key extractor function to get the item title, so they should be fine.

Jacse commented 4 years ago

Ah of course.