search

Jacse / react-native-app-intro-slider

Simple and configurable app introduction slider for react native
MIT License
1.65k stars 330 forks source link

vertical render added and autoplay option added #266

Open poojan010 opened 1 year ago

poojan010 commented 1 year ago

I have added vertical render functionality so now swipe up and down can also be possible also added new prop autoPlay which will be used to scroll slides automatically Indentation is modified with 2 spaces

poojan010 commented 1 year ago

i have implemented the changes you requested @Jacse

Jacse commented 1 year ago

Hi @poojan010 there are a few unresolved comments / questions. Could you also add something to the documentation (maybe include a screenshot as well)?

poojan010 commented 1 year ago

Hi @Jacse I have Fixed unresolved comments / questions and even added screenshots to docs I have used background colours for slides because i did not have images that you used to generate screenshots for basic example

poojan010 commented 1 year ago

@Jacse ^^

Jacse commented 1 year ago

Hi again @poojan010 thanks for the persistence. I'm really sorry to tell you this now, but seeing it I don't think vertical rendering is something we should support. I have a hard time thinking that this is often useful (but I could be wrong). The autoplay I will gladly merge, though.

poojan010 commented 1 year ago

Do you think changing skip and next button UI will make vertical render better ?