search

Jacse / themes-for-brackets

Popular themepack for Brackets. Before official theme support, this extension also added that feature
MIT License
187 stars 69 forks source link

solarized-dark shadow over code #114

Closed PPR35 closed 10 years ago

PPR35 commented 10 years ago

Hi, using the solarized-dark theme, the left column displaying line numbers cast its box shadow over the code. This can be avoided by not displaying the line numbers, but its not as practical. Observed on both Linux and Mac OS.

Jacse commented 10 years ago

This is a design decision. Would you rather have no shadow?

wormeyman commented 10 years ago

@PPR35 You can comment out line 230 if you wish to change how it currently looks but like Jase said this is by design.

.cm-s-Themes-for-Brackets-solarized-dark .CodeMirror-gutters {
/* box-shadow: 0 10px 20px black; */
border-right: 1px solid;
}
PPR35 commented 10 years ago

Thanks for the tip @wormeyman. Works for me. @Jacse : i do not contest the design but the shadow, (with linbe numbers displayed) overlapses on the code itself, therefore the test isn't easily readable at the beginning of the line. And if the linbe numbers aren't displayed, i get a weird white square at the beginning of the selected line. Anyway the quick fix with the comment does the job for me. Thanks again to both of you.

Jacse commented 10 years ago

No problem, closing.