search

Jacse / themes-for-brackets

Popular themepack for Brackets. Before official theme support, this extension also added that feature
MIT License
187 stars 69 forks source link

Dark themes should have a dark toolbar (Linux) #116

Closed martpie closed 8 years ago

martpie commented 9 years ago

Hi,

With some Linux desktop environments, Themes use a custom toolbar and not the system one, the problem is whatever the theme is, it stays white.

Brackets default dark theme: capture du 2014-11-06 10 24 19

example with "Theme for Brackets - MBO" capture du 2014-11-06 10 24 34

This kinda hurts eyes,

best !

wormeyman commented 9 years ago

Thanks i'll look into this.

wormeyman commented 9 years ago

https://github.com/cristatus/brackets-darker/blob/master/main.js

Could we use this as an example? Unfortunately my java script knowledge is pretty limited, @Jacse could you fix this using the other theme pack as an example?

Jacse commented 8 years ago

@wormeyman I'll look into this in the weekend.

Jacse commented 8 years ago

Not quite sure how I'll debug this, considering I don't have a Linux machine, though

Jacse commented 8 years ago

@wormeyman @KeitIG I think we should leverage off this css - it styles the titlebar: https://github.com/cristatus/brackets-darker/blob/master/darker.css

wormeyman commented 8 years ago

I ended up using a virtual machine to test Linux.