Closed nbaroiller closed 10 years ago
Any thoughts @Jacse ? I'm guessing this is because of native themes now.
Yes, since native themes, themes for brackets stopped being permananet, and when Brackets is restarted, default theme is active. imho, native themes are ok, but Themes for Brackets is far superior. They should have just integrated this plugin. Anyways, I really miss my dark soda :D
So I asked Brackets devs what's up with this. The reply i got was: "I think most of the Themes have been converted into separate plugins now, eg. Dark Sodar, Solarized, Delkos, are now separate plugins. So if say you liked Dark Sodar you can install individually now and it appears in the standard Themes menu. I think some have not yet been converted, eg. Obsidian.. So they might only be 2 built in themes, but it's very easy to extend.."
Maybe if @Jacse had the time, he should start moving this project into the native theme selector panel instead of a separate plugin in a separate Brackets dropdown menu. That would be awesome. I mean I tried Dark Soda extension, but Jacse's is much better. Also, hunting down separate themes is a pain in the a, if this plugin could install all its 12 themes into the native theme selection menu, it would stay the #1 themepack for brackets.
edit: 'monokai dark soda' plugin looks exactly like this plugin's dark soda, but my point still stands I guess.
Yes, it is definetely a priority to rebuild this project into a theme-pack, now that native themes have finally landed.
I'm thinking this could become version 2?
v2 makes sense. I think Brackets users are likely to update quickly to newer versions, so I guess time is key. Btw, thanks for the awesome work you've done with this plugin so far.
No problem, glad you like it. I will hopefully make the necessary changes Thursday
Erm, @Jacse theres any way to make your Dark Soda's theme permanent again? D: i really miss it, i cant get along with the Monokai's Dark Soda, please tell me theres a way to do it! Greetings!
Working on it @moo--
Ok guys, want to hear your take on this
As far as I can tell, two things are not supported natively yet:
As per the package.json schema, it does seem that one theme extension can contain only a single style. Styling the UI - it looks like there is a 'dark':true switch which can be used to indicate that your theme has a dark appearance, but that's about it.
I'm not an expert on Brackets Extensions, so I'm just gonna throw in: Would it be possible to create a standard extension, which would then extract/install multiple theme extensions in the brackets plugin folder?
@MikeSpock Technically I think so, but I imagine it would be a bitch to maintain
https://github.com/adobe/brackets/issues/8423 Theme packs will not be supported (natively).
Ok, I think I've figured it out. Now Themes-for-Brackets works with native themes!! https://github.com/Jacse/themes-for-brackets/commit/4f3b3ed595d644daa1bd67303fcb63288e455064
Still a lot of work to do on the themes, but I'm extremely busy so we'll just have to see about that. Scrollbars doesn't work for example.
The Dark Soda theme is very popular, I'm thinking about releasing a standalone with just that, thoughts?
Dark Soda has been released twice i think:
I've just upgraded to Sprint 42 0.42.0-13957 (release f9fcb884f) on Win8 and I'm now encountering this issue with Themes for Brackets 1.7.3: the theme I choose isn't applied to other opened files and whenever I hit F5, I get the standard one for the current file though it's not selected in the dropdown menu. Restarting Brackets didn't help either.