search

JadeMaveric / patronus

A browser extension that listens to your gMeets for you. And notifies you if something important is mentioned
MIT License
10 stars 2 forks source link

Allow users to search for phrases using regex #5

Open JadeMaveric opened 3 years ago

JadeMaveric commented 3 years ago

The current approach of searching for keywords is simple. But not very flexible. Its very possible that some user might want to match keyphrases and not just keywords.

Fortunately, JavaScript already has inbuilt methods to run regex search over strings.

A suitable PR would involve a way for users to input the regex expression (reuse the textfield element currently used for keyword entry). The first fix proposed in #4 should also be implemented, since regex works best over entire sentences. It'll also make migrating to a stream based system easier.

rezziemaven commented 3 years ago

Hi @JadeMaveric! I'd love to take this one on. Would you mind assigning it to me?

JadeMaveric commented 3 years ago

Sure thing @rezziemaven