JadeOfMaar / RationalResources

Strips out CRP default distributions and applies resources by logical body composition
https://forum.kerbalspaceprogram.com/topic/184875-*/
MIT License
7 stars 18 forks source link

Bad install message is incorrect #5

Closed linuxgurugamer closed 4 years ago

linuxgurugamer commented 4 years ago

The INSTALL_LOC stanza in the .version file is not correct. Getting the following dialog:

73617154-bf747b80-45e9-11ea-9edc-ef7dd1737d8a

The problem is in the .version files, in the INSTALL_LOC stanza. You have: "INSTALL_LOC": { "NAME": "JNSQ", "PATH": "RationalResources/Version/RationalResources.version" } but the PATH cannot have the file there. YOu can do one of the following:

"INSTALL_LOC":
{
    "NAME": "RationalResources",
    "PATH": "",
    "DIRECTORY": "RationalResources/Version",
    "FILE": "RationalResources.version"
}

or:

"INSTALL_LOC":
{
"NAME": "RationalResources",
"PATH": "",
"FILE": "RationalResources/Version/RationalResources.version"
}
JadeOfMaar commented 4 years ago

Odd. I don't see this conflict anywhere. It can't be that bad:

"INSTALL_LOC":
{
    "NAME": "JNSQ",
    "PATH": "RationalResources/Version/RationalResources.version"
}

But I did have this error:

"INSTALL_LOC":
{
    "NAME": "Rational Resources",
    "PATH": "RationalResources/Version/RationalResources.version"
}

And I chose option 1 from your fixes. :) Thanks for pointing it out. Fixed: commit in JNSQ, commit in this repo

linuxgurugamer commented 4 years ago

It only shows up if you have MadLad (I think) installed, and it's only a warning

DasSkelett commented 4 years ago

It only shows up if you have MadLad (I think) installed, and it's only a warning

Indeed, the validation happens in MADLAD.

I have a PR open for this since a few days, looks like @JadeOfMaar missed it. There's still a misplaced comma in the version file, so I've left the PR open and rebased it: #4