search

JadePrince / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Code review request #234

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: dev_dougfelt

Purpose of code changes on this branch: support svg image files in tools used 
by website

When reviewing my code changes, please focus on: whether I should use this 
approach (in create_images.py) or minimize changes to existing code by passing 
in an object that creates the cairo surface instead.

After the review, I'll merge this branch into:
/master (there is no /trunk)

Original issue reported on code.google.com by dougf...@google.com on 19 Jan 2015 at 10:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Comments posted on 
https://code.google.com/p/noto/source/detail?r=985fd644478b3874a2117cc241f72af47
88b25fa&name=dev_dougfelt

I like your current approach, except that I don't like the .get() pattern of 
invoking DrawParams.

Original comment by roozbeh@google.com on 21 Jan 2015 at 1:09

GoogleCodeExporter commented 9 years ago 
I responded to your comments on the submit at 
https://code.google.com/p/noto/source/detail?r=985fd644478b3874a2117cc241f72af47
88b25fa&name=dev_dougfelt.  

Fixed two issues, had questions about the first.

The submit with the two fixes is here:

https://code.google.com/p/noto/source/detail?r=d5c9240d47dfef3e7ed433b221efb9312
64d4ae8&name=dev_dougfelt

Original comment by dougf...@google.com on 22 Jan 2015 at 7:54

GoogleCodeExporter commented 9 years ago 
addressed the last issue here: r2aa9d5757559

Original comment by dougf...@google.com on 14 Feb 2015 at 1:35

GoogleCodeExporter commented 9 years ago

Original comment by dougf...@google.com on 17 Feb 2015 at 10:23

GoogleCodeExporter commented 9 years ago

Original comment by jame...@google.com on 18 Feb 2015 at 6:28