JadeVane / Allure

A more beautiful and simple theme for trilium
Mozilla Public License 2.0
85 stars 36 forks source link

Misaligned tab close button and blocks of white background #15

Closed sbstratos79 closed 1 year ago

sbstratos79 commented 1 year ago

Love the theme but it has some major issues that I can't seem to get rid of.

  1. Large blocks of white background.
  2. Misaligned tab close button

Screenshot_20230531_120918 Screenshot_20230531_120928

JadeVane commented 1 year ago

The problems reflected in the screenshots seem to be more than the ones you described. These problems are basically due to the layout changes after the trilium upgrade. However, Allure did not make timely changes to these upgrades, resulting in misplaced layouts.

These problems are not difficult to solve, but I am upgrading the theme recently, hoping to provide a better experience, so I don’t have time to give priority to solving this problem.

The new version of the theme will be launched recently, and some changes will be made to the current theme. At the same time, it will also solve the problem of adapting the new version that you mentioned in this issue. After the latest version is launched, I can notify you under this issue. If you hope

sbstratos79 commented 1 year ago

Looking forward to the update. Thanks!

JadeVane commented 1 year ago

Sorry to make you wait so long, I've been very busy lately, and the issues I encountered during the development process were more troublesome than I thought.

But anyway, the new version has been updated, try it out, then let me know if you have any ideas

sbstratos79 commented 1 year ago

Hi. Thanks for your work. But unfortunately, it seems to be even more broken now. :( Screenshot_20230823_151716

JadeVane commented 1 year ago

Have you upgraded to the latest version of Trilium (0.60.4)?

sbstratos79 commented 1 year ago

Yes. I am on 0.60.4 image

JadeVane commented 1 year ago

The icon files have been updated, have you re-imported the new version of the icon files?

In addition, what is the white part on the right, I don't seem to have seen this

sbstratos79 commented 1 year ago

Updating the icons fixed one of the issues. Thanks!

In addition, what is the white part on the right, I don't seem to have seen this

It's just a scratchpad widget. I got it from here. I don't expect you to fix this since it's a custom widget.

But as you can see in the screenshot, table preview in the "Required Documents" section is completely broken. Is there a way to fix this?

JadeVane commented 1 year ago

Fixed.

It's just a scratchpad widget. I got it from here.

By the way, I like the widget, so I made some simple adaptations to this plugin, and it should work fine now.

Since there are other people who need to use other plugins, I took some time to make a more general adaptation of the plugin, which should make most plugins work

JadeVane commented 1 year ago

I've closed this issue given that it was resolved with a version update. Feel free to reopen this issue if it is still not resolved.

sbstratos79 commented 1 year ago

Hi. I am using the latest version of the theme but there are still some issues. As I mentioned earlier, the table preview in the "Required Documents" section is completely broken. And there is no whitespace between document subheading and paragraph. As you can see in the screenshot, the "Summary" subheading and the lorem ipsum paragraph are joined together. This preview still has a lot of legibility issues. Screenshot_20230901_111211

JadeVane commented 1 year ago

I don’t know much about Required Documents and have never used this feature, but I tried to make some repairs. You can try to see if the latest version solves your problem.