search

Jaded-Encoding-Thaumaturgy / lvsfunc

lvsfunc, a collection of LightArrowsEXE's VapourSynth functions and wrappers
https://lvsfunc.readthedocs.io/
MIT License
52 stars 11 forks source link

descaler is invoked even when it is not used #8

Closed l00tzOMG closed 4 years ago

l00tzOMG commented 4 years ago

I don't know if it is a bug or a feature but the descaler library is invoked, when I wanted to use the edgefixer function. If libdescale.dll is not loaded before calling import lvsfunc VapourSynth throws a missing namespace error referring to line 899 in lvsfunc.py, where descaler is defined. If it is loaded before the import command, the error disappears and the script just runs fine.

As far as I understand descaler is not required for edgefixer...

VapourSynth version: R49-RC1 OS: Win 10 x64

BTW: what is the difference between MonoS's edgefixer and sekrit's one (https://github.com/sekrit-twc/EdgeFixer)?

Thank you very much in advance!

LightArrowsEXE commented 4 years ago

Hello, could you double-check to see if this update fixes it?

The issue was not relevant to edgefixer specifically, but to smarter_descale, since it calls for an object in the parameters. As a fix I've moved it to inside the function, so it should no longer bug you about it unless you call smarter_descale specifically.

As for the differences between MonoS' and sekrit's edgefixers, at base they appear to work basically identically in my eyes. The only difference is that sekrit's version has luminance balancing. I don't think it works all that well though, so I've just stuck with MonoS' version for years now.

Hope this answers all your questions!

l00tzOMG commented 4 years ago

Sweet, it works. Thank you. Now if I import lvsfunc and make a BlankClip no additional libs are required :)

Regarding the difference between the two: thanks for the explanation.