Jaded-Encoding-Thaumaturgy / muxtools

Automation package for everything related to encoding and subbing
Mozilla Public License 2.0
13 stars 9 forks source link

fix: path not returned as str on windows #22

Closed itschasa closed 1 week ago

itschasa commented 1 week ago

When print_cli is set to true on the main mux function, it can fail as sh.which(...) (in utils/download.py:get_executable) does not always return a string and can return a WindowsPath object, causing joincommand(...) (in muxing/mux.py:mux) to fail.

Before change: image

After change: No error (yipee)

Vodes commented 1 week ago

Kinda weird that I never ran into that but fair enough I guess