Jaded-Encoding-Thaumaturgy / vs-deband

Various debanding tools for VapourSynth
MIT License
15 stars 7 forks source link

Simplify `GrainPP.Resolver` #102

Closed sgt0 closed 3 weeks ago

sgt0 commented 1 month ago

griffe (the docs parser used in jet-docs) trips up on the loop of GrainPP -> GrainPP.Resolver -> GrainPP -> GrainPP.Resolver -> etc. Because of this the whole vsdeband.noise module had to be excluded. While this could be fixed in griffe, it also looked like this could be both fixed and simplified by just quoting the type (like 'GrainPP'). This way there's no loop and no need for _gpp.

Also don't need the the explicit type in GrainPostProcessT (8550361) anymore.

Verified that the computed type is the same before and after:

(type) Resolver = (VideoNode) -> GrainPP

Total mypy errors: 71 -> 63.


P.S. It looks like GrainPP.Resolver is not even used anywhere? Maybe ResolverOneClipArgs and ResolverTwoClipsArgs are supposed to supersede it? Unless I'm missing something, I think we can alternatively just remove GrainPP.Resolver and move that alias into GrainPostProcessT.