Jaded-Encoding-Thaumaturgy / vs-denoise

VapourSynth denoising, regression, and motion compensation functions
MIT License
18 stars 6 forks source link

MVTools functions support #69

Closed NSQY closed 1 month ago

NSQY commented 1 year ago
adworacz commented 1 year ago

Also note that the latest (git) version of MVTools (not floating point) supports up to Degrain4-6 now. I added it back on new years.

I'm not sure if that requires any code changes in this package, just wanted to give a heads up.

I'm still working on some other (mostly speed) improvements, particularly when working on higher bit depths.

Setsugennoao commented 1 year ago

Yep i saw your commits. I'll be honest, i didn't update since i didn't want to compile it, and I'm waiting on an official release.

adworacz commented 1 year ago

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

adworacz commented 1 year ago

Also @NSQY - It appears that Recalculate support does exist: https://github.com/Irrational-Encoding-Wizardry/vs-denoise/blob/master/vsdenoise/mvtools.py#L770-L772

So you can update the checklist.

Setsugennoao commented 1 year ago

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

Yeah, i will have to update the check of temporal radius from 3 to 6 and hmm i think i'll be it.

Setsugennoao commented 1 year ago

Also @NSQY - It appears that Recalculate support does exist: https://github.com/Irrational-Encoding-Wizardry/vs-denoise/blob/master/vsdenoise/mvtools.py#L770-L772

So you can update the checklist.

I actually made the checklist based on his initial issue, but i want to have a way of actually manually refining the vector data, I'll have to see and decide the API.

Setsugennoao commented 1 year ago

Super is now decoupled and can be freely used thanks to @adworacz.

Setsugennoao commented 1 year ago

Totally fair. I hope to have a few more tweaks made in the coming weeks (ideally less), and then I think cutting a new release would be appropriate.

And I looked at the code in this repo. If I'm reading things right, it all should "just work", unless I missed something big. Props to how you've written the code (and the crazy dynamic nature of Python).

image Yup, just to confirm, this is the only place where radius support is checked for the int mvtools plugin.

ghost commented 11 months ago

vs-deinterlace depends on FlowInter, so adding this should be a priority IMO.

Setsugennoao commented 1 month ago

Depan won't be added because it's broken in the VS plugin, everything else has been added