search

Jaded-Encoding-Thaumaturgy / vs-denoise

VapourSynth denoising, regression, and motion compensation functions
MIT License
18 stars 6 forks source link

BM3Ds: Certain frame properties get removed #77

Closed LightArrowsEXE closed 1 year ago

LightArrowsEXE commented 1 year ago

With BM3DCuda (and presumably, the core BM3D class in general), certain frame properties get removed at the end of the process. I've verified the same happens with DPIR (see https://github.com/Irrational-Encoding-Wizardry/lvsfunc/issues/158). I have not yet verified what the exact cause is, but a temporary workaround is to simply copy the props of the input clip to the output clip.

LightArrowsEXE commented 1 year ago

After talking about this with Setsu in our PMs, we determined it's probably the RGB conversion. This should be double-checked in multiple functions and fixed if possible.

adworacz commented 1 year ago

Just a note - Full Range content is broken as well, even when setting the range_in parameter properly.

It looks like the BM3D functions don't carry through the input's range properly.